-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added epub support #154
base: master
Are you sure you want to change the base?
Added epub support #154
Conversation
@GjjvdBurg kind nudge to get this moving |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @cvanelteren! I've left a few comments with suggestions. The main suggestion is that EPUB support can be handled by the LocalFile
provider by modifying the base class, which seems simpler. Let me know what you think and whether you're up for making those changes!
Will check the PR tomorrow again. I abstracted some code but the build seems to be failing; local epub files are pushed to the remarkable with the integrated code. |
Same tests pass on the main @GjjvdBurg ✨ |
Hi @cvanelteren, thanks for making the changes, I think it looks good! The build is failing on formatting errors, do you have a chance to fix those? Also, it would be great if we could have a unit test that verifies epub functionality. I'm wondering if there are any good sources for that, maybe something like Project Gutenberg? That could imply adding a provider for it though, which does increase the scope of this PR so we could also merge this after fixing the formatting errors and then add that provider/test later |
Will look into it no worries. |
Thanks for adding the test @cvanelteren! Unfortunately the change to the PdfUrl provider causes the existing |
@GjjvdBurg did check it beforehand but lazily only checked what I added. There was a typo in the check. There are some other tests that fail relating to filenames that changed but I believe that is outside the scope of this PR. |
Can upload epubs to remarkable via the api. Fixes #144